On Fri, 12 Dec 2025 17:18:49 GMT, Damon Nguyen <[email protected]> wrote:
>>> I have switched to a single frame at a time >> >> This makes the test much slower. On my machine, the execution time is:: >> - ~33s with the one at a time version >> - ~10s for version with all gcs in batches of 20 >> >> Few notes on placing several frames: >> <img width="1012" height="222" alt="image" >> src="https://github.com/user-attachments/assets/98820fd5-5c9e-4f9c-b2d4-a87681a56cb6" >> /> >> - If they are close enough, they can cast shadows on each other. >> - If the auto-hide dock is disabled, the dock can overlap frames. The dock >> auto-hide is enabled on the CI, but it would be better if it could be moved >> away from the screen border. > > Is 33 seconds unreasonable for the test? I figured since the upper-limit of > frame tests is set to 30, this 33 seconds would be the longest the test would > run for. Also, the test only has 1 gc for other OS's so only 1 frame is > tested for that. This avoids the shadow issue as well as creates a more > stable test. I will take stability at the cost of some extra time. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28646#discussion_r2615132807
