On Thu, 4 Jun 2026 05:06:24 GMT, Prasanta Sadhukhan <[email protected]> wrote:
>> test/jdk/javax/swing/JMenuItem/TestRadioAndCheckMenuItemWithIcon.java line >> 78: >> >>> 76: a checkmark is shown alongside the imageicon. >>> 77: >>> 78: Also, verify the JMenuItem "MenuItem2" red square imageicon >>> location. >> >> This test doesn't cover the case where we have icons and checks sharing a >> column. >> That is one of the key things we need to test. >> Also that is very specific to the Windows L&F and this test currently is not. >> It just sets the system L&F. (Did you test GTK & Aqua too )? >> >> I think that on windows it needs to add a 2nd menu and extra instructions >> for that special windows case. >> >> Also the instructions could use some updates. >> Starting with the first line which says >> "A top level Menu will be shown." >> better would be >> "A window is displayed which has a Menu on the menu bar." >> >> and I'd say "icon" not "imageicon" or at least "image icon" ... >> >> And "vertically aligned" could be misconstrued. >> Perhaps say something like "the red square images are not all the same size >> but should their left edges should all be aligned". >> >> BTW this presumes LTR layout and I suggested that we need to test RTL too. > >> Also that is very specific to the Windows L&F and this test currently is not > > The test has jtreg tag @requires (os.family == "windows")...SInce this is > manual test, I did not add a platform check inside the test as it relies on > jtreg tag as it uses PassFailJFrame which can be run with jtreg > > The test is updated with 2nd menu > > >> BTW this presumes LTR layout and I suggested that we need to test RTL too > > There is already a RTL test in the repo and the fix is tested against that > test/jdk/javax/swing/JMenuItem/RightLeftOrientation.java As discussed, test made applicable for all L&F ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29730#discussion_r3360146741
