On Fri, 12 Jun 2026 03:01:43 GMT, Prasanta Sadhukhan <[email protected]> wrote:
>> test/jdk/javax/swing/JMenuItem/TestRadioAndCheckMenuItemWithIcon.java line >> 31: >> >>> 29: * JRadioButtonMenuItem and JCheckboxMenuItem >>> 30: * is rendered with ImageIcon in WindowsLookAndFeel >>> 31: * @requires (os.family == "windows") >> >> Why are we removing the restriction to Windows? > > Phil asked to make it applicable for all L&F and all platforms as in most L&F > it works.. > I have added a line in the instructions that it needs to be tested for > Windows L&F A line in the instructions isn't good enough, in my opinion. Yes, `PassFailJFrame` doesn't support iterating over all the installed Look-and-Feels, but we already have a few tests which workaround this limitation by providing a set of `@test` comments, for example [`JFileChooser/HTMLFileName.java`](https://github.com/openjdk/jdk/blob/master/test/jdk/javax/swing/JFileChooser/HTMLFileName.java). Since this test targets primarily Windows L&F, running the test in Windows L&F should be *the default mode*, it shouldn't require a tester or a developer to modify the test or to pass additional flags to jtreg. Otherwise, we could easily miss a regression because the test wasn't run in the L&F where the problem occurred. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29730#discussion_r3692746207
