On Fri, 10 Jul 2026 14:57:09 GMT, Matthias Baesken <[email protected]> wrote:
>> [JDK-8387298](https://bugs.openjdk.org/browse/JDK-8387298) removed the >> IS_WINXP macro, and the updated code in ComCtl32Util::UnsubclassHWND and >> ComCtl32Util::DefWindowProc doesn't use the _DefWindowProc parameter any >> more. >> >> Thus, the _DefWindowProc parameter can be removed from these functions. >> >> Removing these parameters requires updating all the usages of the functions, >> for example, in awt_Component.cpp, awt_Choice.cpp... >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Matthias Baesken has updated the pull request incrementally with two > additional commits since the last revision: > > - DefWindowProc related comment removed > - Remove NativeDialogWndProcProp src/java.desktop/windows/native/libawt/windows/awt_Choice.cpp line 101: > 99: void AwtChoice::Dispose() { > 100: if (m_hList != NULL) { > 101: ComCtl32Util::GetInstance().UnsubclassHWND(m_hList, > ListWindowProc); Is this call even needed any more ? And is m_listDefWindowProc needed any more ? SFAICS it was assigned via a call to ComCtl32Util::GetInstance().SubclassHWND(m_hList, ListWindowProc); and this UnSubclassHWND() call is to remove it .. so perhaps both can go. And maybe some of the other cases are the same. But it needs to be understood and a bunch of testing done. I think this PR is getting a bit more complex than you may have expected. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31814#discussion_r3606356491
