On Tue, 21 Jul 2026 09:30:12 GMT, Alexey Ivanov <[email protected]> wrote:
>> Hi Phil, good point! >> From what I see >> https://github.com/search?q=repo%3Aopenjdk%2Fjdk%20m_listDefWindowProc&type=code >> >> after this PR, only the declaration of `WNDPROC m_listDefWindowProc;` >> (awt_Choice.h) and 2 assignments (awt_Choice.cpp) are left >> `m_listDefWindowProc = NULL;` and `m_listDefWindowProc = >> ComCtl32Util::GetInstance().SubclassHWND(m_hList, ListWindowProc);` . >> >> So we only write/assign the variable but never use it after this PR. >> Should I remove it too in this PR ? >> >> Btw. wondering why we get no compiler warning because of the variable >> `m_listDefWindowProc` now? > >> wondering why we get no compiler warning because of the variable >> m_listDefWindowProc now? > > `m_listDefWindowProc` is a class member… C++ may not issue a warning for > members that are never used. But I digress… Makes sense, thanks for the explanation! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31814#discussion_r3628509984
