On Thu, 16 Jul 2026 12:11:48 GMT, Matthias Baesken <[email protected]> wrote:

> There is some handling for ancient Windows versions in AwtTrayIcon::InitNID 
> which most likely can be removed.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Hi Simon, thanks for the comment.  However we do not support XP and Vista any 
more so no need to handle it.
But I am not sure about Win 7 / 8.
Could we simply use the `IS_WIN8` macro from awt.h  (which means Win8 and 
higher) 
https://github.com/openjdk/jdk/blob/b61ef6bd260fd1468573b4370587df5494ad8db0/src/java.desktop/windows/native/libawt/windows/awt.h#L157


if (IS_WIN8) { // Win 8 and later
  m_nid.cbSize = sizeof(m_nid);
} else {
  m_nid.cbSize = (BYTE *)(&m_nid.hBalloonIcon) - (BYTE *)(&m_nid.cbSize);
}


so we can avoid the `JDK_LoadSystemLibrary` call ?
On the other hand, from the docs I found it might be that on Win8 the 
shellVersion is 6 too; but I could not verify it.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/31930#issuecomment-5019584406

Reply via email to