On 20/07/2026 08:01, Matthias Baesken wrote:
On Thu, 16 Jul 2026 12:11:48 GMT, Matthias Baesken<[email protected]> wrote:
Hi Simon, thanks for the comment. However we do not support XP and Vista any
more so no need to handle it.
But I am not sure about Win 7 / 8.
Could we simply use the `IS_WIN8` macro from awt.h (which means Win8 and
higher)
https://github.com/openjdk/jdk/blob/b61ef6bd260fd1468573b4370587df5494ad8db0/src/java.desktop/windows/native/libawt/windows/awt.h#L157
if (IS_WIN8) { // Win 8 and later
m_nid.cbSize = sizeof(m_nid);
} else {
m_nid.cbSize = (BYTE *)(&m_nid.hBalloonIcon) - (BYTE *)(&m_nid.cbSize);
}
so we can avoid the `JDK_LoadSystemLibrary` call ?
On the other hand, from the docs I found it might be that on Win8 the
shellVersion is 6 too; but I could not verify it.
-------------
PR Comment:https://git.openjdk.org/jdk/pull/31930#issuecomment-5019584406
Thanks for this. I have done some web searching and from what I have found, it appears that the code in the PR webrev that always sets the size to sizeof(m_nid)
is correct for Windows 7 and later. This means that the code in the PR webrev is correct as it stands.
Simon
