On Wed, 29 Jul 2026 04:18:38 GMT, Prasanta Sadhukhan <[email protected]> wrote:
>> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove any optimization in pruneEdges and update test summary > > test/jdk/java/awt/geom/Area/AreaPath2DDrawTest.java line 28: > >> 26: * @bug 8386576 >> 27: * @summary Checks that when we calculate Area of a path it results >> 28: * in proper geometry and no horizontal spurious lines are > > This proper geometry check is not done..we only check if centre column > contains no non-white pixels...It doesn't check that the expected circle > outline was drawn, so an all-white/empty result would pass, it seems...I > think we should check for positive presence of a known perimeter pixel or > validate that the resulting Area contains the expected outline This regression test is added to verify the functional regression of paths getting closed between the edges when it should not. Visually this is seen as horizontal lines within the circle(Attachment in JBS shows this) that we are trying to draw. And mathematically the horizontal lines will be drawn at exact same place always for the given edges. So checking most of the center column pixels is more than sufficient to verify this regression. We are not trying to verify whether the whole circle is getting drawn properly. May be the summary was misleading, i have corrected the same. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31971#discussion_r3674034384
