On Fri, 7 Aug 2026 02:30:36 GMT, Prasanta Sadhukhan <[email protected]> wrote:
>> Aqua classes for text components enables dragEnabled by default although >> setDragEnabled spec cites `"The default value of the dragEnabled property is >> false. "` and there is nothing in Aqua L&F that mentions otherwise as to why >> the default is overridden. >> Other L&F dont override the mode and the code is there from macosx port days >> so it seems to be an oversight. >> >> The code is deleted. >> Test is added to check >> - default value is honoured in all installed L&Fs >> - explicit application setting of drag mode is preserved on L&F change >> >> CI testing is ok. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > Review comment test/jdk/javax/swing/text/JTextComponent/TextComponentDragEnabledTest.java line 31: > 29: * @run main TextComponentDragEnabledTest > 30: */ > 31: Could we verify the headless behaviour too ? i.e there could be a separate @test block that doesn't specify the headful key and does run main -Djava.awt.headless=true Then in the test if headless is true, only test the defaults. The point being that the default should never cause a HeadlessException. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32101#discussion_r3738139027
