On Wed, 12 Aug 2026 05:15:19 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
>> test/jdk/javax/swing/text/JTextComponent/TextComponentDragEnabledTest.java
>> line 94:
>>
>>> 92: for (UIManager.LookAndFeelInfo laf :
>>> 93: UIManager.getInstalledLookAndFeels()) {
>>> 94: UIManager.setLookAndFeel(new MetalLookAndFeel());
>>
>> Why is it necessary to set new MetalLookAndFeel() here? Is the goal to check
>> the transition from all installed L&Fs one by one, or the transition from
>> MetalLookAndFeel to other L&Fs?
>>
>> It will be good to test serialization patched in the last commit as well.
>
> The intended goal is to check the application set property value is preserved
> during transition from one L&F to Aqua since intended L&F being tested is
> Aqua and since Metal is present everywhere so I wanted to check from Metal ->
> Aqua,
> but the testing is extended for all installed L&F to check preservation is
> honoured for transition from Metal to any L&F not just Aqua
> Checking for all possible combination will be too much for this regression
> test.
But why it sets UIManager.setLookAndFeel(new MetalLookAndFeel()) at the start
and then loop over different components resetting the L&F? It looks like a
wrong/suspicion order?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32101#discussion_r3826681902
