On Mon, 14 Sep 2026 17:31:40 GMT, Phil Race <[email protected]> wrote:

> This PR
> * replaces the use of GetPrimitiveArrayCritical with GetIntArrayElements
> * updates the test 
> java/awt/image/BufferedImage/ICMColorDataTest/ICMColorDataTest.java to make 
> it run for less time
> * removes the test from the Problem list
> 
> The bug https://bugs.openjdk.org/browse/JDK-8233028 remains open as the test 
> is still a whole lot slower on Windows, but the removal of 
> GetPrimitiveArrayCritical eliminates one problem.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

test/jdk/java/awt/image/BufferedImage/ICMColorDataTest/ICMColorDataTest.java 
line 40:

> 38:  *          it should not crash
> 39:  * @requires os.maxMemory >= 1G
> 40:  * @run main/othervm/timeout=300 -Xms200m -Xmx200m ICMColorDataTest

In my testing, this completes on windows (on our CI systems) in 30 seconds. So 
300 seconds seems like sufficient headroom to avoid spurious failures but not 
so great that it will cause an entire set group of tests to time out or hide a 
truly pathological problem.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32862#discussion_r4007948812

Reply via email to