On Mon, 14 Sep 2026 18:29:33 GMT, Phil Race <[email protected]> wrote:
>> This PR >> * replaces the use of GetPrimitiveArrayCritical with GetIntArrayElements >> * updates the test >> java/awt/image/BufferedImage/ICMColorDataTest/ICMColorDataTest.java to make >> it run for less time >> * removes the test from the Problem list >> >> The bug https://bugs.openjdk.org/browse/JDK-8233028 remains open as the test >> is still a whole lot slower on Windows, but the removal of >> GetPrimitiveArrayCritical eliminates one problem. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Phil Race has updated the pull request incrementally with one additional > commit since the last revision: > > 8392349 src/java.desktop/share/native/libawt/awt/image/BufImgSurfaceData.c line 362: > 360: initInverseGrayLut(pRgb, bisdo->lutsize, cData); > 361: } > 362: (*env)->ReleaseIntArrayElements(env, bisdo->lutarray, pRgb, 0); Suggestion: (*env)->ReleaseIntArrayElements(env, bisdo->lutarray, pRgb, JNI_ABORT); For consistency with the line 354, and it looks like that copying back is not needed here. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32862#discussion_r4012487852
