On Fri, 9 Oct 2026 22:05:06 GMT, Phil Race <[email protected]> wrote:
>> This adds some extra checks/validation affecting the ImageIO JPEG writer
>> plugin
>>
>> The cases are
>> - the constructor for a JPEGHuffmanTable validates the array parameters and
>> copies after the validation. It would take the application to be doing
>> something very odd for this to be a problem, but there's no cost in doing
>> the copy before hand.
>>
>> - ImageIO's native JPEG library is compiled to support baseline JPEG only.
>> This means 8 bit quantization values in the range 1 -> 255. the image I/o
>> native glue code should enforce this.
>>
>> - The native glue code has no explicit check for null Huffman table data .
>> This isn't normally possible, but direct manipulation of a meta data tree
>> can be used to force it. In which case we have a null de-ref crash. A simple
>> check for null should fix this. I was able to devise a test for this,
>> although it is very contrived code.
>>
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JpegQTableTest.java
test/jdk/javax/imageio/plugins/jpeg/JpegQTableTest.java line 48:
> 46: import org.w3c.dom.NodeList;
> 47:
> 48: public class JpegQTableMetadataTest {
Mismatch between filename and test name
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33217#discussion_r4251896945
