On Wed, 14 Oct 2026 22:11:08 GMT, Phil Race <[email protected]> wrote:
>8 bit samples is what is important. Progressive 8 bit does not change anything. I think we talk about different things. My initial point was only this: >So I do not think this is accurate: >ImageIO's native JPEG library is compiled to support baseline JPEG only. This >means 8 bit quantization values in the range 1 -> 255. "baseline JPEG only" in that text is not correct. The library is not compiled for baseline only, otherwise progressive would have to be dropped as well. It is compiled for 8 bit samples, and that is what the PR description should say, and that is what I pointed out, so that argument is not used as a reason later. It would be good to document this in JBS and possibly by the release-note, since this is a behavior change (dropping an extended behavior of libjpeg), not only a bug fix. >What crash ? I'm not seeing any crash, nor fixing a crash. ... as usual bugs just stick to me.... I thought this clamp was a guard, and checking that code path I found that with some specific values it causes a crash. Your "< 1" clamp fixes it. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33217#discussion_r4278491452
