On Thu, 22 Oct 2026 12:32:03 GMT, Matthias Baesken <[email protected]> wrote:

> The gcc static analyzer reports this issue :
> 
> `src/java.desktop/unix/native/common/java2d/x11/X11Renderer.c:86:17: warning: 
> use of possibly-NULL 'malloc((long unsigned int)newMax * 4)' where non-null 
> expected [CWE-690] [-Wanalyzer-possible-null-argument]`
> 
> Seems we miss NULL checks in the XDHD_ADD_POINT macro (for malloc).
> 
> While at it, should I NULL check realloc too?
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Btw. should we check `jint newMax` for overflows or is this considered too 
obscure/unrealistic in this coding?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/33513#issuecomment-6361646730

Reply via email to