On Mon, 26 Oct 2026 08:27:33 GMT, Matthias Baesken <[email protected]> wrote:
> > That's all part of the same code so I would include it here. > > Makes sense. I adjusted it too. Btw while browsing through ProcessPath.c I > found this ALLOC - macro > > https://github.com/openjdk/jdk/blob/7245a8b25cd19b1fc367ceada45886e7d5fcccd9/src/java.desktop/share/native/libawt/java2d/loops/ProcessPath.c#L1726-L1735 > > (including a 19 years old TODO to add the NULL-check after malloc ; the > realloc - related macro seems to be unused) It isn't clear to me if the idea was to have some error handling in that ALLOC macro but how to make it do the right thing for an unknown caller context ? I see only 2 usages, and they are just a few lines apart. I suggest to delete both macros, which add little value as it stands, even for the used one, and replace it with directly calling malloc and doing error handling all without the macro. ------------- PR Comment: https://git.openjdk.org/jdk/pull/33513#issuecomment-6425947228
