On Mon, 26 Oct 2026 12:19:35 GMT, Matthias Baesken <[email protected]> wrote:

>> When testing the gcc flag '-Wunused-macros' to warn about unused macros, a 
>> couple of unused macros have been reported by the compiler, that could be 
>> removed.
>> 
>> https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wunused-macros
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Matthias Baesken has updated the pull request incrementally with two 
> additional commits since the last revision:
> 
>  - freetypeScaler COPYRIGHT
>  - Bring back old java.desktop

src/java.base/share/native/libverify/check_code.c line 452:

> 450:         ((type *)CCalloc(context, (count)*(sizeof(type)), JNI_FALSE))
> 451: #define ZNEW(type, count) \
> 452:         ((type *)CCalloc(context, (count)*(sizeof(type)), JNI_TRUE))

Seems like `jboolean zero` parameter for `CCalloc` is no longer needed after 
this removal.

src/jdk.hotspot.agent/linux/native/libsaproc/ps_proc.c line 157:

> 155:   }
> 156:   return true;
> 157: #elif defined(PTRACE_GETREGS_REQ)

Do we still need this old code? `PTRACE_GETREGSET` exists since Linux 2.6.34. 
Shouldn't it always be defined? Even on Alpine?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33468#discussion_r4399140544
PR Review Comment: https://git.openjdk.org/jdk/pull/33468#discussion_r4399241876

Reply via email to