On Wed, 28 Oct 2026 10:05:23 GMT, Martin Doerr <[email protected]> wrote:

>> Matthias Baesken has updated the pull request incrementally with two 
>> additional commits since the last revision:
>> 
>>  - freetypeScaler COPYRIGHT
>>  - Bring back old java.desktop
>
> src/jdk.hotspot.agent/linux/native/libsaproc/ps_proc.c line 157:
> 
>> 155:   }
>> 156:   return true;
>> 157: #elif defined(PTRACE_GETREGS_REQ)
> 
> Do we still need this old code? `PTRACE_GETREGSET` exists since Linux 2.6.34. 
> Shouldn't it always be defined? Even on Alpine?

Good question, probably we can remove it. But I am not 100% sure when it became 
available in user-space headers  and if there are differences between 
CPU-architectures.
Should I remove the fallback and always count on PTRACE_GETREGSET ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33468#discussion_r4400120790

Reply via email to