On Mon, 16 Nov 2026 11:35:03 GMT, Timofei Fedotov <[email protected]> wrote:

> SplashDecodeJpeg() allocates bitmap storage using stride * height as a signed 
> int expression. SAFE_TO_ALLOC checks an unsigned 32-bit bound, so it can 
> accept a mathematical product above INT_MAX. The allocation expression then 
> has signed overflow and undefined behavior.
> 
> If bitmap allocation fails, the function frees splash->frames but leaves its 
> pointer and frameCount unchanged. The buffer-allocation failure path has the 
> same ownership problem. A subsequent SplashCleanup(), including cleanup after 
> an unsuccessful startup splash decode, can read freed frame storage and 
> attempt to free it again.
> 
> An example size is width 65500, height 16000, and four bytes per pixel: the 
> product is 4192000000, which passes the existing unsigned size guard but 
> exceeds INT_MAX.
> 
> Expected behavior: size calculation must not overflow signed arithmetic, and 
> failure must leave no freed frame storage reachable by cleanup.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Btw. what about this multiplication
https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/native/libsplashscreen/splashscreen_impl.c#L149
(stride * height, both int), should we guard/check there too ?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/33915#issuecomment-6948253627

Reply via email to