On Tue, 17 Nov 2026 14:50:41 GMT, Matthias Baesken <[email protected]> wrote:

> Some more are here
> 
> https://github.com/openjdk/jdk/blob/8b5481d43fb8d4a922873a03070a0def806daa83/src/java.desktop/share/native/libsplashscreen/splashscreen_png.c#L115
> 
> 
> https://github.com/openjdk/jdk/blob/8b5481d43fb8d4a922873a03070a0def806daa83/src/java.desktop/share/native/libsplashscreen/splashscreen_png.c#L154
> 
> 
> (those at least have a SAFE_TO_ALLOC check, but considering your comments it 
> might be not sufficient)

Thanks for pointing these out. The rowbytes * height multiplication uses 
unsigned operands and is guarded by SAFE_TO_ALLOC, so it does not have the same 
signed overflow issue.

However, the bitmap allocation uses signed integers and the preceding stride 
calculation may also overflow. I will extend the fix to cover the corresponding 
PNG allocation and cleanup paths soon.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/33915#issuecomment-6969941346

Reply via email to