Hi,

On Feb 11, 12:57 am, Wardrop <t...@tomwardrop.com> wrote:

> As part of my second question, could someone take a look at the code
> I've posted and tell me if it's a good implementation and follows
> clojure idioms and standards.

I haven't checked the algorithm itself, but just some random notes
after skimming the code:

 * lazy-seq should wrap the whole thing! (lazy-seq (when-let [coll
(seq coll)] ...)
 * take-while and afterwards a drop can be done with split-with in one
go.
 * You could use condp: (condp = on-cons :join (do-stuff) :split (do-
otherstuff) (throw ...))

Sincerely
Meikel

-- 
You received this message because you are subscribed to the Google
Groups "Clojure" group.
To post to this group, send email to clojure@googlegroups.com
Note that posts from new members are moderated - please be patient with your 
first post.
To unsubscribe from this group, send email to
clojure+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/clojure?hl=en

Reply via email to