I dug a bit deeper to see where :js-globals came from and found the old
ticket for this exact issue: http://dev.clojure.org/jira/browse/CLJS-680
I propose that we remove it, because it's unnessecary when we gensym fn
names the same way as let bindings + blacklists are never a great solution,
but in the case of an open set of names (such as globals that can differ
from runtime to runtime), they are particularly awful.
Ad reproducing the issue: Can the shadowing mechanism be influenced by
compiler flags such as :advanced?
2014-08-04 14:43 GMT+02:00 Herwig Hochleitner <hhochleit...@gmail.com>:
> That's curious, here's my console interaction:
>
> % git remote show origin
> * remote origin
> Fetch URL: git://github.com/clojure/clojurescript.git
> Push URL: git://github.com/clojure/clojurescript.git
> % git fetch origin && git checkout -b master origin/master
>
> Branch master set up to track remote branch master from origin.
> Switched to a new branch 'master'
> % rm -rf out && ./script/clean && ./script/bootstrap
> Fetching ...
> [Bootstrap Completed]
> % git am < 0001-CLJS-833-Test-for-fn-name-shadowing.patch
> Applying: CLJS-833 Test for fn-name shadowing
> % ./script/test
> out/core-advanced-test.js:1333:205 Error: Assert failed: (identical? js
> js/eval)
> % cat out/cljs/core_test.js | tail -n 11 | head -n1
> var eval_7329 = (function eval(){return new
> cljs.core.PersistentArrayMap(null, 2,
> [cljs.core.constant$keyword$133,eval,cljs.core.constant$keyword$105,eval],
> null);
>
> ----------------------
>
> As you can see, I start from a freshly cleaned cljs checkout and apply the
> test patch from the ticket. In the last line, you can see that it is indeed
> called (function eval(){}).
>
> My latest two entries from % git log are (after applying my test-case
> patch):
>
> commit d8d8f58df51db7246a2c92f1f863cff502dbcc45
> Author: Herwig Hochleitner <her...@bendlas.net>
> Date: Mon Aug 4 11:08:12 2014 +0200
>
> CLJS-833 Test for fn-name shadowing
>
> commit aa048ad64743ef51538c55163b86a90a02a8940d
> Merge: 7de3636 bb3adca
> Author: David Nolen <david.no...@gmail.com>
> Date: Sat Aug 2 10:45:54 2014 -0400
>
> Merge branch 'master' of github.com:clojure/clojurescript
>
> Could you please confirm, that you can't reproduce the issue with the
> latest master from github, or point me to where I'm doing something stupid?
>
> kind regards
>
--
You received this message because you are subscribed to the Google
Groups "Clojure" group.
To post to this group, send email to clojure@googlegroups.com
Note that posts from new members are moderated - please be patient with your
first post.
To unsubscribe from this group, send email to
clojure+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/clojure?hl=en
---
You received this message because you are subscribed to the Google Groups
"Clojure" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to clojure+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
