It's not safe to change the JavaScript base types directly - besides the obvious down sides of global changes to types you don't control, this often triggers dramatic de-optimization in JavaScript engines.
David On Sun, Sep 6, 2015 at 12:27 PM, Shaun LeBron <shaunewilli...@gmail.com> wrote: > I just looked at the implementation, and it's not done 'from the outside' > for cljs types. `extend-type` adds protocol methods to the type object's > prototype. Only exception is for JS base types (e.g. "function", "number", > "array"). You can see the effects in this gist: > https://gist.github.com/shaunlebron/a98a05b47a1521b58a6b > > Not sure why though > > > > On Sunday, September 6, 2015 at 7:01:02 AM UTC-5, Yehonathan Sharvit wrote: > > On Friday, 4 September 2015 20:42:46 UTC+3, Scott Nelson wrote: > > > OK, thanks. Great documentation by the way. Definitely going to > refer to this from now on. > > > > Francis, > > > > Do you have an ide yhy the implementation of `extend-type` for: > > 1. js types modifies the js type itself > > 2. while for cljs types it modifies the protocol (from the outside)? > > -- > Note that posts from new members are moderated - please be patient with > your first post. > --- > You received this message because you are subscribed to the Google Groups > "ClojureScript" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to clojurescript+unsubscr...@googlegroups.com. > To post to this group, send email to clojurescript@googlegroups.com. > Visit this group at http://groups.google.com/group/clojurescript. > -- Note that posts from new members are moderated - please be patient with your first post. --- You received this message because you are subscribed to the Google Groups "ClojureScript" group. To unsubscribe from this group and stop receiving emails from it, send an email to clojurescript+unsubscr...@googlegroups.com. To post to this group, send email to clojurescript@googlegroups.com. Visit this group at http://groups.google.com/group/clojurescript.
