> On Sept. 6, 2012, 7:04 p.m., Koushik Das wrote: > > server/src/com/cloud/user/AccountManagerImpl.java, line 311 > > <https://reviews.apache.org/r/6858/diff/5/?file=150231#file150231line311> > > > > Is this a valid assumption? If possible try to avoid the id and use > > some other data.
Added in new patch. - saksham ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6858/#review11119 ----------------------------------------------------------- On Sept. 7, 2012, 10:07 a.m., saksham srivastava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6858/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2012, 10:07 a.m.) > > > Review request for cloudstack, Devdeep Singh, Nitin Mehta, and Alena > Prokharchyk. > > > Description > ------- > > Added global setting login.attempts.allowed which defines the maximum > incorrect password attempts allowed. > Also after the maximum attempts are reached the user account is disabled. > > > This addresses bug CS-10219. > > > Diffs > ----- > > core/src/com/cloud/user/UserAccountVO.java 5e7c018 > server/src/com/cloud/configuration/Config.java ebcd070 > server/src/com/cloud/configuration/ConfigurationManagerImpl.java f9da08d > server/src/com/cloud/user/AccountManagerImpl.java 38153f3 > setup/db/create-schema.sql fa933e3 > setup/db/db/schema-302to40.sql aaf23e6 > > Diff: https://reviews.apache.org/r/6858/diff/ > > > Testing > ------- > > Verified locally. > > > Thanks, > > saksham srivastava > >
