----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6858/#review11162 -----------------------------------------------------------
core/src/com/cloud/user/UserAccountVO.java <https://reviews.apache.org/r/6858/#comment23873> Change to incorrect_login_attempts in DB and here server/src/com/cloud/configuration/Config.java <https://reviews.apache.org/r/6858/#comment23874> LoginAttemptsAllowed --> InccorectLoginAttemptsAllowed Also is this setting for user or account - please be clear ? server/src/com/cloud/user/AccountManagerImpl.java <https://reviews.apache.org/r/6858/#comment23875> suggestion - create a function is systemAccount. server/src/com/cloud/user/AccountManagerImpl.java <https://reviews.apache.org/r/6858/#comment23878> it shouldn't be acct. it should be user server/src/com/cloud/user/AccountManagerImpl.java <https://reviews.apache.org/r/6858/#comment23877> Can you suggest him corrective action ? Like contacting him an admin or resetting his password. What options does he have. I think there should be an alert generated to alert the admin that the user got locked. Also there should be an option to try infinitely like we have today.(may be setting it to -1). Its not fair to ask u to implement it right away but please file a bug for this. setup/db/db/schema-302to40.sql <https://reviews.apache.org/r/6858/#comment23876> The string here should be same as for the fresh install "Incorrect login attempts allowed before the account is disabled" - Nitin Mehta On Sept. 7, 2012, 10:07 a.m., saksham srivastava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6858/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2012, 10:07 a.m.) > > > Review request for cloudstack, Devdeep Singh, Nitin Mehta, and Alena > Prokharchyk. > > > Description > ------- > > Added global setting login.attempts.allowed which defines the maximum > incorrect password attempts allowed. > Also after the maximum attempts are reached the user account is disabled. > > > This addresses bug CS-10219. > > > Diffs > ----- > > core/src/com/cloud/user/UserAccountVO.java 5e7c018 > server/src/com/cloud/configuration/Config.java ebcd070 > server/src/com/cloud/configuration/ConfigurationManagerImpl.java f9da08d > server/src/com/cloud/user/AccountManagerImpl.java 38153f3 > setup/db/create-schema.sql fa933e3 > setup/db/db/schema-302to40.sql aaf23e6 > > Diff: https://reviews.apache.org/r/6858/diff/ > > > Testing > ------- > > Verified locally. > > > Thanks, > > saksham srivastava > >
