----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8307/#review13963 -----------------------------------------------------------
I tested this and see at least one problem. It's looking for a '.' as a delimiter - which means files like docs/en-US/added-API-commands-4.0.xml generate the below - which is problematic. Perhaps instead of using .split on line 37 you can slice instead (which assumes only .xml files (which need to be tested for as there are also .ent files in that directory that should not be included)) [ACS_DOCS.added-API-commands-4] file_filter = <lang>/added-API-commands-4.po source_file = pot/added-API-commands-4.pot source_lang = en type = PO - David Nalley On Dec. 2, 2012, 1:29 a.m., Kelcey Jamison-Damage wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8307/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2012, 1:29 a.m.) > > > Review request for cloudstack. > > > Description > ------- > > Utility for generating the .tx/config file > > Long names are truncated and suffixed with -long, and duplicates are > numerically tagged. > > > Diffs > ----- > > docs/doc-config-gen.py PRE-CREATION > > Diff: https://reviews.apache.org/r/8307/diff/ > > > Testing > ------- > > tested against dupes and long names in en-US. uses relative paths so must be > executed from /docs > > > Thanks, > > Kelcey Jamison-Damage > >
