> On Dec. 17, 2012, 6:40 p.m., Rohit Yadav wrote:
> > Pl. fix those evil trailing whitespaces and tabs (no tabs, only whitespaces 
> > please).
> > Not sure if we should it this way. Probably the whole user and project 
> > management should be moved out of cloudstack as an adapter or business 
> > layer. (not sure about the best way, no flames please :)
> 
> Isaac Chiang wrote:
>     Hi Rohit: 
>               I'm agree with you. This isn't the best way to solve the issue 
> but a temporary one. Once when CloudStack change its architecture (move out 
> the user and project management as an adapter like you said), I believe we 
> can have a better solution for it. Thanks for the reply :)
> 
> Rohit Yadav wrote:
>     Sure thanks but that is a long way to go, I sense dark forces around that 
> goal.
>     I think we should get it merged sometime soon. Let's wait for some of the 
> CS jedi to show up and guide us.

I've tested, it's good enough at this moment. 
For the long term solution, we can hold discuss in mailing list.


- Gavin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8637/#review14595
-----------------------------------------------------------


On Dec. 18, 2012, 2:16 a.m., Isaac Chiang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8637/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2012, 2:16 a.m.)
> 
> 
> Review request for cloudstack and Gavin Lee.
> 
> 
> Description
> -------
> 
> This patch is to fix the CLOUDSTACK-436 issue described in 
> https://issues.apache.org/jira/browse/CLOUDSTACK-648.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/api/response/UserResponse.java 920eb59 
>   client/tomcatconf/commands.properties.in 149547e 
>   server/src/com/cloud/api/ApiDBUtils.java 3b5f634 
>   server/src/com/cloud/api/ApiResponseHelper.java ebe8415 
>   ui/scripts/accounts.js 324c5f5 
>   ui/scripts/sharedFunctions.js f1b7efa 
> 
> Diff: https://reviews.apache.org/r/8637/diff/
> 
> 
> Testing
> -------
> 
> 1. A CloudStack normal user can modify its own password.
> 2. Domain admin can change it's domain user's password, including subdomain 
> admins and subdomain users.
> 3. In the same domain, a domain admin cannot update cannot modify another 
> domain admin's password.
> 
> 
> Thanks,
> 
> Isaac Chiang
> 
>

Reply via email to