> On Dec. 25, 2012, 1:04 p.m., Gavin Lee wrote: > > Ship It!
Hi, Isaac Thank for this patch & sorry for my late reply. Please close as submitted. - Gavin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8637/#review14889 ----------------------------------------------------------- On Dec. 18, 2012, 2:16 a.m., Isaac Chiang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8637/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2012, 2:16 a.m.) > > > Review request for cloudstack and Gavin Lee. > > > Description > ------- > > This patch is to fix the CLOUDSTACK-436 issue described in > https://issues.apache.org/jira/browse/CLOUDSTACK-648. > > > Diffs > ----- > > api/src/com/cloud/api/response/UserResponse.java 920eb59 > client/tomcatconf/commands.properties.in 149547e > server/src/com/cloud/api/ApiDBUtils.java 3b5f634 > server/src/com/cloud/api/ApiResponseHelper.java ebe8415 > ui/scripts/accounts.js 324c5f5 > ui/scripts/sharedFunctions.js f1b7efa > > Diff: https://reviews.apache.org/r/8637/diff/ > > > Testing > ------- > > 1. A CloudStack normal user can modify its own password. > 2. Domain admin can change it's domain user's password, including subdomain > admins and subdomain users. > 3. In the same domain, a domain admin cannot update cannot modify another > domain admin's password. > > > Thanks, > > Isaac Chiang > >