----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9157/#review16636 -----------------------------------------------------------
server/src/com/cloud/configuration/ConfigurationManagerImpl.java <https://reviews.apache.org/r/9157/#comment35308> Move this logic to Cmd class itself. server/src/com/cloud/migration/ServiceOffering21VO.java <https://reviews.apache.org/r/9157/#comment35309> When is file getting used. What scenario? server/src/com/cloud/service/ServiceOfferingVO.java <https://reviews.apache.org/r/9157/#comment35310> Fix tab/spacing server/src/com/cloud/vm/UserVmManagerImpl.java <https://reviews.apache.org/r/9157/#comment35311> Why do you need vmId instead if the VM object itself as it has already been fetched in rebbotVM and restoreVM methods setup/db/db/schema-40to410.sql <https://reviews.apache.org/r/9157/#comment35306> Fix is not going to 4.1 so this file shouldn't be changed. This should be moved to something like 41to42.sql - Koushik Das On Feb. 6, 2013, 2:41 p.m., Harikrishna Patnala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9157/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2013, 2:41 p.m.) > > > Review request for cloudstack, Abhinandan Prateek and Koushik Das. > > > Description > ------- > > CLOUDSTACK-745: Reset a VM on reboot > To have a method to reset the vm on its reboot. > So on reboot, the vm's disk is discarded and creates a new root disk using > the template. > The use cases for this are > -> Secure environments that need a fresh start on every boot > -> Desktops that should not retain state > > > This addresses bug CLOUDSTACK-745. > > > Diffs > ----- > > api/src/com/cloud/offering/ServiceOffering.java 4d71589 > api/src/org/apache/cloudstack/api/ApiConstants.java d29408e > > api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java > ee1e1b2 > server/src/com/cloud/configuration/ConfigurationManager.java 5c1b0d5 > server/src/com/cloud/configuration/ConfigurationManagerImpl.java 750b8b8 > server/src/com/cloud/migration/ServiceOffering21VO.java fdec30e > server/src/com/cloud/service/ServiceOfferingVO.java c199a86 > server/src/com/cloud/vm/UserVmManagerImpl.java 390a2a2 > server/test/com/cloud/vm/UserVmManagerTest.java PRE-CREATION > server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 574ce0a > setup/db/create-schema.sql f89c885 > setup/db/db/schema-40to410.sql 6d5b262 > > Diff: https://reviews.apache.org/r/9157/diff/ > > > Testing > ------- > > Did the manual testing locally > > > Thanks, > > Harikrishna Patnala > >
