On 8/5/2011 5:14 PM, Alexander Neundorf wrote:
(2) The documentation of the module has a few typos.  Please
proofread it again.  Also, please use the word "compatible" rather
than "suitable" to refer version acceptability.  This makes the
distinction noted above in (1).

I hope it's better now. But I didn't merge it yet to next.

The use of unsuitable in the implementation looks good, but see below.

(3) After noting the implementation detail with configure_file the
documentation should state that users should never directly configure
the files themselves.

Done.

I don't see any commits on the WriteConfigVersionFile_2TemplateFiles
topic that make changes to the main module file.  Where did you put
the new documentation changes?

Thanks,
-Brad
_______________________________________________
cmake-developers mailing list
cmake-developers@cmake.org
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Reply via email to