2011/10/13 Nicolas Desprès <nicolas.desp...@gmail.com>: > 2011/10/13 Brad King <brad.k...@kitware.com>: >> On 10/12/2011 11:10 AM, Nicolas Desprès wrote: >>> >>> I have extracted some documentation patches I have made while I was >>> working on the ninja-generator and some enhancement for ccmake. I >>> would like to submit them now. They are addressing: >>> - usage messages >>> - doxygen documentation >>> - online help in ccmake >> >> Fantastic. This is a lot of tedious cleanup work. Thanks for doing it! >> Here are a few comments from review: >> >> - The "Factor toggle key help instructions" commit adds lines longer than >> 79 characters. Please reformat them to use shorter lines. >> >> - Some of the patches remove trailing whitespace from lines unrelated to >> the real change. Please identify the set of files from which you've >> blanket-removed whitespace, create a commit that does just that, and >> then rebase the rest of the patches on it. That will make the changes >> easier to see/review/blame. >> >> - Please prefix each commit message with the section affected, when >> applicable. For example, "ccmake: " or "doxygen: ". > > Thanks for the review. I have fix all the remarks. Shall I send the > patch again via the mailing list or shall I push them on github and > you will fetch them. Sending many patches to the mailing list make the > post moderated. Tell me what is the easiest for you. >
Pushed on my github: https://github.com/polrop/CMake/commits/some-documentation-fixes -- Nicolas Desprès -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
