2011/10/13 Brad King <brad.k...@kitware.com>: > On 10/13/2011 2:14 PM, Nicolas Desprès wrote: >> >> 2011/10/13 Nicolas Desprès<nicolas.desp...@gmail.com>: >>> >>> Thanks for the review. I have fix all the remarks. >> >> Pushed on my github: >> https://github.com/polrop/CMake/commits/some-documentation-fixes > > That looks pretty good. I have two more comments: > > - The following commits add lines over 79 characters that weren't already: > > "ccmake: Align 'g' and 'q' key instructions." > "Usage: Document all options printing the version number."
Done. > > - The commit "Doxygen: Fix warnings." modifies some *Lexer.cxx files > which are actually flex-generated sources created from the *.in.l > versions. The modifications to the comments should be made in both > files so that the next time we regenerate the lexers the comments > are preserved. Unfortunately the comments do not appear in the .in.l so I think this is flex which generate non-valid Doxygen comments. I pushed the new version. Cheers, -- Nicolas Desprès -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
