On 3/17/2012 8:26 PM, Peter Collingbourne wrote:

Most likely some object files were not rebuilt as a result of header
file changes.  This will happen if the compiler does not support
emitting dependency files, such as cl.exe.  I think there are a couple
of ways we could consider supporting cl.exe here:

1) Integrate CMake's built in dependency scanner.  This will require
    some thought because the dependency scanner works on a per-target
    basis and Ninja reads dependency files on a per-file basis.

2) Come up with a way to use cl.exe's /showIncludes option to build a
    dependency list.  There has been some discussion of this topic on
    the Ninja mailing list:
    
https://groups.google.com/group/ninja-build/search?group=ninja-build&q=showincludes&qt_g=Search+this+group

Oh my....


So, the windows ninja generator IMO is totally useless right now... Without depend information on .h files incremental builds just won't work. I wonder if this is why the BuildDepend test is failing... If not, we should certainly add a test that touches a .h file and makes sure things rebuild. BuildDepend is also failing on the Mac, does ninja have the same issue with llvm?

This looks like it should work:
https://github.com/sgraham/ninja/blob/master/misc/cldeps.cc

https://groups.google.com/group/ninja-build/browse_thread/thread/5d73ad7d26fba84d/898d7f0c808a32b0?lnk=gst&q=showincludes#898d7f0c808a32b0

Is there a chance of getting this moved to master in ninja? Can we move it to the ninja windows binary that we are using for CMake?

-Bill







--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Reply via email to