We should re-factor it sooner (not later). This is great, thank you very much!
But we should definitely re-factor it before merging it to 'master' Thx, David On Fri, Jul 6, 2012 at 7:05 AM, Nicolas Desprès <nicolas.desp...@gmail.com> wrote: > I forgot to say that most of the code is duplicated from the Makefile > generator. I have left some todo but this code will need to be > factored sooner or later. > > On Fri, Jul 6, 2012 at 12:54 PM, Nicolas Desprès > <nicolas.desp...@gmail.com> wrote: >> Hi, >> >> I finally found the time to fix the Ninja generator on OS X. Mainly I >> have fixed ExportImport and Qt4Deploy. I based my work on jkp's work >> (https://github.com/jkp/CMake/commits/jkp/ninja-generator). Although >> there are other patches in this branch, I just included commits fixing >> tests. We could later add more tests if required. I also had a minor >> issue with CMake.Install because my Qt4, installed with Homebrew, did >> not have write access. You can find my patches here: >> https://github.com/polrop/CMake/commits/ninja-fix-macosx. I have >> tested my work on Linux too but not on Windows. I don't think my patch >> will break Windows, but we never know so I did not enable Ninja on >> MacOSX yet. I prefer to wait for a green dashboard. >> >> Cheers, >> Nico > > > > -- > Nicolas Desprès > -- > > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Please keep messages on-topic and check the CMake FAQ at: > http://www.cmake.org/Wiki/CMake_FAQ > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
