On Mon, Jul 29, 2013 at 2:25 PM, Stephen Kelly <steve...@gmail.com> wrote:
> Nicolas Desprès wrote: > > >> Also, I don't see why the custom comparison functor is needed at all. I > >> removed it and sped up the test significantly. Can you explain? > >> > > > > I had some failing tests because the previous algorithm was not a plain > > strcpy(). > > I don't see any strcpy(). Anyway, I think that's as much useful review I > can > do for you. I think Brad will have to do the rest. > > Arg. Sorry for being unclear (English is not my mother tongue). The std::less<string> comparator do the same thing (as strcpy() < 0). Unfortunately, we cannot use it here because the previous (O(N)) implementation of cmMakefile::GetSourceFileWithOutput(const char*) was more complex than that (have a look to the code my path replaces). Of course, I first tried with the default comparator to save me some work but some tests were failing. Namely: ExportImport and CustomCommand. Hope this help. Thanks for your time. -Nico
-- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
