2013/7/29 Brad King <brad.k...@kitware.com>: > On 07/29/2013 04:59 AM, Vadim Zhukov wrote: >> Thank you, Alexander. I've fixed both points you've mentioned and >> merged the "add-cmake_reset_check_state" branch into the "next". > > Let's complete the add-cmake_reset_check_state topic first and > then you can rebase the find_backtrace topic on it to use the > feature. The former looks good but we'll let it run through the > dashboards tonight first.
Thank you for looking in. I'll follow this plan then. > One comment on the latter topic: > > + # Prepend list with library path as it's more common practice > + set(_Backtrace_STD_ARGS Backtrace_LIBRARIES ${_Backtrace_STD_ARGS}) > > The FPHSA macro should be given Backtrace_LIBRARY since that is > what the user might modify, no? Yep, you're right. I've just pushed the fix to stage. -- WBR, Vadim Zhukov -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers