Roger Leigh wrote: > Dear Chuck, > > Thanks for looking at this. Please find attached a new copy of the > patch which should address all your points. If you would like any > further changes making, please just let me know.
I don't think you need the functions for anything, especially not _Xerces_FIND. From what I can tell they only serve the purpose of not leaking variables. The only thin protected in _Xerces_FIND are the version components, that could easily be fixed by just returning the concatenated version string from the inner function. What I would find more useful is actually checking that Xerces_INCLUDE_DIR is set before calling _Xerces_GET_VERSION(), otherwise you would try to open "/xercesc/util/XercesVersion.hpp", which is definitely wrong. Eike --
signature.asc
Description: This is a digitally signed message part.
-- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
