Am Dienstag, 19. August 2014, 23:29:13 schrieb Roger Leigh: > On Sun, Aug 17, 2014 at 03:43:46PM +0100, Roger Leigh wrote: > > On Sun, Aug 17, 2014 at 03:46:14PM +0200, Rolf Eike Beer wrote: > > > > Sorry for the naïve question, but the find_package docs also mentions > > > > setting package_VERSION_COUNT but I don't see any examples of this in > > > > cmake git. Is setting the MAJOR/MINOR/PATCH versions here correct or > > > > redundant or plain wrong? Or all handled internally by > > > > FIND_PACKAGE_HANDLE_STANDARD_ARGS? I'm just a little confused between > > > > the difference between the documentation and the actual examples in > > > > Modules/Find*. > > > > > > That variable is automatically set by CMake and will tell you how many > > > components were found in the version passed to find_package. > > > > Ah, OK. I've tidied up the version handling as you suggested, new patch > > attached. > > I found a minor mistake in the sphinx docs which is fixed > in the attached updated patch (underline not long enough).
I will pick up both of your modules during the remainder of the week and push it to next. I will however drop the documentation lines about how to invoke find_package in both at it is redundant to the find_package documentation. No need to send an updated patch for this, I will remove those few lines myself. Eike
signature.asc
Description: This is a digitally signed message part.
-- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
