On 09/05/2014 03:53 PM, Brad King wrote:
> I think "CMAKE_GENERATOR_PLATFORM" may be a suitable name. Ideally
> this setting should be added as a general-purpose replacement for
> putting "ARM" or "Win64" in the generator name. The changes for
> that are more sweeping than I'd like to ask of you just for WinCE
> support, so I drafted them myself.
This is now in 'master'.
On 09/04/2014 06:42 AM, Bach, Pascal wrote:
>> At the beginning of this block you should check/reject when
>> the generator name specified a platform name. Something like:
>>
>> if(this->PlatformName != "Win32")
>> {
>> cmOStringStream e;
>> e << "CMAKE_SYSTEM_NAME is 'WindowsCE' but CMAKE_GENERATOR "
>> << "specifies a platform too: '" << this->GetName() << "'";
>> mf->IssueMessage(cmake::FATAL_ERROR, e.str());
>> return false;
>> }
>
> This won't' work as the code gets called multiple times
Along with the above changes I also made SetSystemName not
get called more than once. The "PlatformName" member is
now "DefaultPlatformName". Initially it corresponds to the
default based on the generator name, so you should be able
to check it as shown above.
SetSystemName can modify DefaultPlatformName for specific
systems to have a different default in case
CMAKE_GENERATOR_PLATFORM is not set. The value of that
setting is then processed by SetGeneratorPlatform.
-Brad
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers
