On 10/07/2014 12:18 PM, Rolf Eike Beer wrote:
>>> +  add_library(CMake::Threads INTERFACE IMPORTED GLOBAL)
>>
> Both issues should be fixed now.

Thanks.  Your use of an interface target for this is a clever way
of abstracting the differences between libraries and flags.  Nice.

I'd rather reserve the CMake:: imported target namespace for future
use.  The convention in other Find modules is to prefix the imported
targets with the name of the package.  In this case we have no good
name for the library within the namespace.  Here is a brainstorming
list of possible names:

 Threads::Threads
 Threads::Interface # my favorite
 Threads::Native
 Threads::System

Please pick one of these or propose your own and update the topic.

Thanks,
-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Reply via email to