Am Mittwoch, 8. Oktober 2014, 10:54:12 schrieb Brad King: > On 10/07/2014 12:18 PM, Rolf Eike Beer wrote: > >>> + add_library(CMake::Threads INTERFACE IMPORTED GLOBAL) > > > > Both issues should be fixed now. > > Thanks. Your use of an interface target for this is a clever way > of abstracting the differences between libraries and flags. Nice.
All credits go to Timo Rothenpieler, I just refactored his changes and pushed this upstream. > I'd rather reserve the CMake:: imported target namespace for future > use. The convention in other Find modules is to prefix the imported > targets with the name of the package. In this case we have no good > name for the library within the namespace. Here is a brainstorming > list of possible names: > > Threads::Threads > Threads::Interface # my favorite > Threads::Native > Threads::System > > Please pick one of these or propose your own and update the topic. I'm not sure about Threads::Interface, it sounds so "generic" or "abstract" to me, but this target offers no abstraction of the thread API. All others have different up- and downsides, so I think I'll stay with Threads::Threads, that is the one that probably results in the least blame for a badly chosen name. Eike
signature.asc
Description: This is a digitally signed message part.
-- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
