On 12/22/2014 02:44 AM, Christoph Grüninger wrote:
> please find attached a patch that introduces components handling for
> optional LaTeX executable.

Thanks for working on this.

> Maybe we should deprecate the old variables name?

The names should not be changed at all.  They become cache entries
that people may be setting in their scripts on the command line, or
have set in existing build trees.  Also the names are visible to the
human in cmake-gui so calling them "..._FOUND" does not make sense.

The FPHSA component handling still leaves it to the module code to
specify whether each component was found.  Therefore you should just
use a pattern like this:

 find_program(LATEX2HTML_CONVERTER ...)
 if (LATEX2HTML_CONVERTER)
   set(LATEX_LATEX2HTML_FOUND 1)
 else()
   set(LATEX_LATEX2HTML_FOUND 0)
 endif()

Once you have that explicit mapping then you can optionally use
lower-case component names.  I have no strong preference on that
though.

Thanks,
-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Reply via email to