On 12/22/2014 6:29 PM, Christoph Grüninger wrote:
> please find attached a new patch following your latest suggestions.

Thanks.

> I'd like to have lower case components but I dislike mixed-cased
> variable names. The latter feeling is stronger.

Mixed-case variable names are quite common in CMake APIs,
especially when dealing with components like this, but
I don't have a strong feeling either way on this.

However, the _FOUND variables are not cache entries so they
do not need to appear in mark_as_advanced.

> -find_package_handle_standard_args(Latex
> +find_package_handle_standard_args(LATEX

Good catch.  The capitalization should match the name of the
find module.  This was a mistake in the original FPHSA change
for FindLATEX.

Thanks,
-Brad
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Reply via email to