On 01/27/2015 01:31 PM, Brad King wrote: > On 01/27/2015 01:22 PM, Robert Goulet wrote: >> If the flag would be wrong, compilation would fail. > > What if the flag is not added at all because the property is ignored? > The test needs to be something that would fail without this change.
I revised the test to add preprocessor definitions as flags and check for them in the .hlsl sources. I also fixed the /Fh flag value to be quoted to work with a space in the path. Revised commit: VS: Add source file property to set extra hlsl shader flags http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=4775c901 -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
