On 03/24/2015 11:54 AM, Brad King wrote: > I added some more commits to tweak a few things too:
And a few more to fix our continuous testing results: GHS: Do not use C++11 enum name scope http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a4427fa9 GHS: Use !foo.empty() instead of foo.size() > 0 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=54828b82 GHS: Do not use string::back() that is missing on VS 7.1 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=dbc9f8c6 > I will squash all those in once you've okay-ed them and we've finished > the topic with clean nightly testing. > > Meanwhile, please continue work based on commit ed1ee3d4 and send > patches against that. In particular, please convert the C++ coding > style as follows: > > * Use "this->" on all member accesses inside methods. > * Place "{" on its own line indented with the content inside the > block. > > This is the style used in the rest of CMake so it will be more > consistent to maintain that way. Please do this based on commit dbc9f8c6 instead. Also, several of the places that test for and add a trailing slash could be ported to use ConvertToUnixSlashes instead. That always removes trailing slashes and would also fix any backslashes specified by project code in property values. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
