>> I added some more commits to tweak a few things too: > >And a few more to fix our continuous testing results: > >GHS: Do not use C++11 enum name scope >http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a4427fa9 > >GHS: Use !foo.empty() instead of foo.size() > 0 >http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=54828b82 > > GHS: Do not use string::back() that is missing on VS 7.1 > http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=dbc9f8c6
Thanks. That's good to know.
> Please do this based on commit dbc9f8c6 instead.
The attached patches should be based on that commit and then made sequentially.
>>> * Place "{" on its own line indented with the content inside the
Made the changes in patch 1. I used the attached clang format file.
>> > * Use "this->" on all member accesses inside methods.
Made the changes in patch 2.
> Also, several of the places that test for and add a trailing slash could be
> ported to use ConvertToUnixSlashes instead. That always removes trailing
> slashes and would also fix any backslashes specified by project code in
> property values.
Made the changes in patch 3.
The total changes were tested:
https://open.cdash.org/buildSummary.php?buildid=3743400. I'll test it on my
internal projects.
Geoffrey Viola
SOFTWARE ENGINEER
asirobots.com
This message contains confidential information and is intended only for the
recipient. If you are not the named addressee you should not disseminate,
distribute or copy this e-mail. Please notify the sender immediately if you
have received this e-mail by mistake and delete this e-mail from your system.
Finally, the recipient should check this email and any attachments for the
presence of viruses. The company accepts no liability for any damage caused by
any virus transmitted by this email.
0003-cleaned-up-trailing-slash-logic.patch
Description: 0003-cleaned-up-trailing-slash-logic.patch
0001-broke-lines-after-curly-brace-in-GHS-CPP-files.patch
Description: 0001-broke-lines-after-curly-brace-in-GHS-CPP-files.patch
0002-added-this-to-member-accesses-in-GHS-CPP-files.patch
Description: 0002-added-this-to-member-accesses-in-GHS-CPP-files.patch
_clang-format
Description: _clang-format
-- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
