Nice!!

I agree with Eike: perhaps you could start the patch series by putting the
verbose explanation in the text of the first commit, and explain "the
following 8... commits all help to minimize the diffs between CMake
generated project files and Xcode native project files."

I love it when people get into cleaning stuff up - little things like this
make all the difference when you're trying to analyze how something's put
together.

Thanks for the effort


On Monday, April 13, 2015, Rolf Eike Beer <e...@sf-mail.de> wrote:

> Am Montag, 13. April 2015, 21:37:57 schrieb Gregor Jasny:
> > Hello,
> >
> > this patch series aims to minimize deltas between the CMake Xcode
> > generator and Xcode itself. It was started by the observation that
> > if one makes any change to the project within Xcode (e.g. to see
> > how a variable is called internally) the user cannot diff the CMake
> > project and the one stored by Xcode afterwards.
> >
> > The major difference now is that Xcode objects are sorted before
> > project generation so that they appear sorted within the individual
> > sections.
> >
> > Indention is done by using tabs instead of seven spaces.
> >
> > I tested this series with Xcode 6.3 and Xcode 3.2. Both show a
> > reduced diff after this series was applied.
>
> This explanation will be lost when the patches are applied, therefore I
> would
> like to see parts of these text in the individual commit messages, e.g.
> just
> add a "as Xcode itself does" to the change from spaces to tabs.
>
> Greetings,
>
> Eike
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Reply via email to