Le 17/04/15 15:50, Raffi Enficiaud a écrit :
Le 16/04/15 22:31, Brad King a écrit :
On 04/16/2015 04:19 PM, Domen Vrankar wrote:
I've pushed the patch with minor changes to next.
http://www.cmake.org/gitweb?p=cmake.git;h=0779b679
Thanks. The "fixup! " mark is useful only during incremental
development of an open topic. Once a commit is in 'master'
then it should be explicitly referenced by a later fixup commit
with a normal commit message. I've revised the commit as:
CPack: Fix single component packaging
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ed0b0630
I also rebased it back on the original commit and renamed the
topic to match. This makes it look like one topic that was
merged to master in the middle.
-Brad
Ok, here is a patch that shows you the advance. This is not yet a
candidate for merging to anything, but rather a support for some
discussions.
It is based on ed0b063 for this particular topic.
I added the following functionalities:
- set the permissions of the md5sum to RW-R--R--, because lintian complains
- added an option to set the shlibdeps per component
- added an option to set the dependencies per component
- added an option to set the description per component
- enforcing the lower case policy of Debian for package names (in the
file, due to the comment "# debian policy enforce lower case for package
name")
On the other hand, I started writing tests based on the one existing for
the CPackComponentsAll, but specific to debian packages:
- added a function for running lintian and checking for some errors. The
md5sum permission change is now covered by that
- added a function for running dpkg-deb and extracting a particular
field of the package metadata. No change I made are currently covered by
this function, this is what I will do next.
- Having one specific check file per configuration, sharing a common
.cmake providing the check functions (linitian and dpkg-deb). This would
prevent the cluttering of the checks that we can observe in the
CPackComponentsAll final test.
Of course, your comments are more than welcome.
Sorry that was too quick. Here are the open questions:
- if a component depends on another component, should we add the
dependency automatically?
- What about the version of this dependency?
Let's say I have components A and B, and B depends on A. I am at version X.
Dependencies of A are d11, d12, d1N,
Dependencies of B are d21, d22, d2P
Should the generation of the package B include d2(P+1)= "A (= versionX)" ?
Best,
Raffi
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers
