Huebl, Axel wrote: > This commit adds VERSION support for HDF5 from > the same sources as it adds the HDF5_IS_PARALLEL > flag.
> @@ -343,6 +346,14 @@ if( NOT HDF5_FOUND ) > if( HDF5_HAVE_PARALLEL_DEFINE ) > set( HDF5_IS_PARALLEL TRUE ) > endif() > + > + file( STRINGS "${_dir}/H5pubconf.h" > + HDF5_VERSION_DEFINE > + REGEX "#define H5_VERSION" ) I suggest using "#define[ \t]+H5_VERSION[ \t]+": this works also on changed indendation and does not accidentially match H5_VERSION_FOO. > + if( "${HDF5_VERSION_DEFINE}" MATCHES > + "H5_VERSION[ \t]+\"([0-9]+\\.[0-9]+\\.[0-9]+)\"" ) > + set( HDF5_VERSION "${CMAKE_MATCH_1}" ) > + endif() please unset HDF5_VERSION_DEFINE here. Greetings, Eike
signature.asc
Description: This is a digitally signed message part.
-- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers