On 05/13/2015 02:58 AM, Huebl, Axel wrote:
> Thanks for merging and adding the test, that is great.
Thanks for working on the patch.
On 05/11/2015 07:32 AM, Huebl, Axel wrote:
> I would simply use
>
> if( "${HDF5_VERSION_DEFINE}" MATCHES
> "H5_VERSION[ \t]+\"([0-9]+\\.[0-9]+\\.[0-9]+).*\"" )
>
> to match the group correctly.
We could also consider moving the ".*" inside the match group
and then reporting the result in HDF5_VERSION_STRING instead
of HDF5_VERSION. Many other find modules do this. The value
can still be used for version testing but the full version
string will be available for human reference.
-Brad
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers
